Discussion:
calculate subsurface's bounding box
zou lan
2018-08-30 10:24:31 UTC
Permalink
Hi pekka & all

I find function weston_view_update_transform_enable() function will
calculate view's bounding box, but after that function,
weston_view_update_transform will update subsurface's scissor region by
parent surface's region, the code is in weston_view_transfer_scissor(). But
the sub view's bounding box is not going to recalculated. Is it a problem?

weston_view_update_transform(struct weston_view *view)
{
.....
weston_view_update_transform_enable();
......
if (parent) {
if (parent->geometry.scissor_enabled) {
view->geometry.scissor_enabled = true;
weston_view_transfer_scissor(parent, view);
} else {
view->geometry.scissor_enabled = false;
}
}
}


Best Regards
Nancy
Pekka Paalanen
2018-08-31 08:39:55 UTC
Permalink
On Thu, 30 Aug 2018 18:24:31 +0800
Post by zou lan
Hi pekka & all
I find function weston_view_update_transform_enable() function will
calculate view's bounding box, but after that function,
weston_view_update_transform will update subsurface's scissor region by
parent surface's region, the code is in weston_view_transfer_scissor(). But
the sub view's bounding box is not going to recalculated. Is it a problem?
weston_view_update_transform(struct weston_view *view)
{
.....
weston_view_update_transform_enable();
......
if (parent) {
if (parent->geometry.scissor_enabled) {
view->geometry.scissor_enabled = true;
weston_view_transfer_scissor(parent, view);
} else {
view->geometry.scissor_enabled = false;
}
}
}
Hi Nancy,

an interesting question, but unfortunately all that has been paged out
of my brain and I don't have the time to concentrate on that at the
moment. It might be worth a bug report to investigate.


Thanks,
pq

Loading...